test: moving H1/H2 shared tests into their own file.#5941
Merged
alyssawilk merged 5 commits intoenvoyproxy:masterfrom Feb 14, 2019
Merged
test: moving H1/H2 shared tests into their own file.#5941alyssawilk merged 5 commits intoenvoyproxy:masterfrom
alyssawilk merged 5 commits intoenvoyproxy:masterfrom
Conversation
… files Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
actual_protocol_test
branch
from
23d9c3d to
7f7a3e6
Compare
| srcs = [ | ||
| "protocol_integration_test.cc", | ||
| ], | ||
| shard_count = 3, |
Member
There was a problem hiding this comment.
From my own edification, how did you pick these shard counts? Maybe a comment here and elsewhere?
Contributor
Author
There was a problem hiding this comment.
Oh, the first time I ran them they were annoyingly long (I default to a 60s timeout for integration tests) so I just sharded them until they were comparable.
Commented in the build file for posterity :-)
mattklein123
approved these changes
Feb 14, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
_Risk Level_: Low _Testing_: all tests pass _Docs Changes_: n/a _Release Notes_: n/a Most of envoyproxy#5638 (there's a little clean up left) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: all tests pass
Docs Changes: n/a
Release Notes: n/a
Most of #5638 (there's a little clean up left)